christianV/CrazeAnalytix
1
0
Fork 0
mirror of https://github.com/christianvidalwolf-prog/CrazeAnalytix.git synced 2026-08-03 14:45:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: exhaustive visibility fix for Sales/Ads data including inclusive filtering and permissive header validation

Browse Source
This commit is contained in:
Christian Vidal Wolf
2026-04-16 11:49:48 +02:00
parent adf72f6f96
commit 348821cd49
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/dataProcessor.ts
+8 -8
View File
@@ -325,17 +325,17 @@ export const validateSellOutHeaders = (headers: string[]) => {
const hasYear = normHeaders.includes('year') || hasDateCol;
const hasTime = normHeaders.includes('month') || normHeaders.includes('week') || hasDateCol;
const hasCustomerRef = normHeaders.includes('customer reference') || normHeaders.includes('asin');
const hasEan = normHeaders.includes('ean');
const hasUnits = normHeaders.includes('units');
const hasAmount = normHeaders.includes('amount_eur') || normHeaders.includes('amount');
const hasEan = normHeaders.includes('ean') || normHeaders.includes('isbn');
const hasUnits = normHeaders.includes('units') || normHeaders.includes('qty') || normHeaders.includes('cantidad');
const hasAmount = ['amount_eur', 'amount', 'sell out', 'sellout', 'revenue', 'sales', 'valor'].some(a => normHeaders.includes(a));
const missing = [];
if (!hasYear) missing.push('YEAR');
if (!hasTime) missing.push('MONTH or WEEK');
if (!hasCustomerRef) missing.push('CUSTOMER REFERENCE');
if (!hasEan) missing.push('EAN');
if (!hasCustomerRef) missing.push('CUSTOMER REFERENCE / ASIN');
// EAN is optional now to prevent crashes with different report formats
if (!hasUnits) missing.push('UNITS');
if (!hasAmount) missing.push('AMOUNT_EUR');
if (!hasAmount) missing.push('AMOUNT / SALES');
if (missing.length > 0) {
throw new Error(`Invalid or missing critical columns in Sell-Out Report. Missing: ${missing.join(', ')}`);
@@ -1057,7 +1057,7 @@ export const filterAdsData = (
// Country/Customer match (ads use 'country', sales use 'customer')
const countryMatch = filters.customer.length === 0
? PAN_EU_COUNTRIES.some(c => c.toUpperCase() === ad.country.toUpperCase())
? true // Show all countries by default
: filters.customer.some(c => c.toUpperCase() === ad.country.toUpperCase());
// Year match
@@ -1162,7 +1162,7 @@ export const filterData = (
// 2. Filter Checks
const customerMatch = filters.customer.length === 0
? (PAN_EU_COUNTRIES.includes(item.customer) || item.customer === 'Pan-EU')
? true // When no filter is selected, show EVERYTHING by default
: filters.customer.includes(item.customer);
const yearMatch = filters.year.length === 0 || filters.year.includes(item.year.toString());