fix(mkt): ensure all ad spend is aggregated correctly in MKT tab including unassigned spend

This commit is contained in:
Christian Vidal Wolf
2026-03-12 17:07:13 +01:00
parent eb20fe2878
commit 753b312412
+22 -12
View File
@@ -168,23 +168,27 @@ export default function MktDataView({ rawData, adsData }: MktDataViewProps) {
unitsMap.set(asin, (unitsMap.get(asin) || 0) + r.units); unitsMap.set(asin, (unitsMap.get(asin) || 0) + r.units);
}); });
// ASIN → global ad spend (all filtered data, no hardcoded year) // ASIN → global ad spend
// Include ALL records (even empty ASIN) so total matches ADs Weekly tab
const adsSpendMap = new Map<string, number>(); const adsSpendMap = new Map<string, number>();
let totalAdsPassed = 0;
adsData.forEach(r => { adsData.forEach(r => {
const asin = r.asin.trim().toUpperCase(); const asin = r.asin.trim().toUpperCase();
adsSpendMap.set(asin, (adsSpendMap.get(asin) || 0) + r.cost); adsSpendMap.set(asin, (adsSpendMap.get(asin) || 0) + r.cost);
totalAdsPassed += r.cost;
}); });
// Deals/Promos/Chargebacks are 2025-only data — only apply when 2025 is in scope // Deals/Promos/Chargebacks
const has2025 = rawData.some(r => r.year === 2025) || adsData.some(r => r.year === 2025); const has2025 = rawData.some(r => r.year === 2025) || adsData.some(r => r.year === 2025);
const getDeals = (asin: string) => has2025 ? (dealsMap.get(asin) || 0) : 0; const getDeals = (asin: string) => has2025 ? (dealsMap.get(asin) || 0) : 0;
const getPromos = (asin: string) => has2025 ? (promosMap.get(asin) || 0) : 0; const getPromos = (asin: string) => has2025 ? (promosMap.get(asin) || 0) : 0;
const getChargebacks = (asin: string) => has2025 ? (chargebacksMap.get(asin) || 0) : 0; const getChargebacks = (asin: string) => has2025 ? (chargebacksMap.get(asin) || 0) : 0;
// Build products from sales ASINs // 1. Start with all sales-based ASINs
const products = Array.from(metaMap.entries()) const products: Product[] = Array.from(metaMap.entries())
.map(([asin, meta]): Product => ({ .map(([asin, meta]): Product => {
const spend = adsSpendMap.get(asin) || 0;
adsSpendMap.delete(asin); // Mark as processed
return {
id: asin, id: asin,
asin, asin,
sku: meta.sku, sku: meta.sku,
@@ -194,22 +198,23 @@ export default function MktDataView({ rawData, adsData }: MktDataViewProps) {
brand: '', brand: '',
grossSales: sellOutMap.get(asin) || 0, grossSales: sellOutMap.get(asin) || 0,
unitsSold: unitsMap.get(asin) || 0, unitsSold: unitsMap.get(asin) || 0,
ppcSpend: adsSpendMap.get(asin) || 0, ppcSpend: spend,
deals: getDeals(asin), deals: getDeals(asin),
promos: getPromos(asin), promos: getPromos(asin),
chargebacks: getChargebacks(asin), chargebacks: getChargebacks(asin),
chargebacksPrevMonth: 0, chargebacksPrevMonth: 0,
cogs: 0, cogs: 0,
})); };
});
// Add ASINs (or unassigned spend) that have ad spend but no sales records // 2. Add remaining ad spend (including "" ASIN and ASINs without sales)
adsSpendMap.forEach((spend, asin) => { adsSpendMap.forEach((spend, asin) => {
if (!metaMap.has(asin) && spend > 0) { if (spend === 0) return;
products.push({ products.push({
id: asin || '__unassigned__', id: asin || '__unassigned__',
asin: asin || '—', asin: asin || '—',
sku: '', sku: '',
name: asin ? asin : 'Unassigned Ad Spend', name: asin ? asin : 'Unassigned Ad Spend (incl. Sponsored Brands)',
image: '', image: '',
category: 'Other', category: 'Other',
brand: '', brand: '',
@@ -222,9 +227,14 @@ export default function MktDataView({ rawData, adsData }: MktDataViewProps) {
chargebacksPrevMonth: 0, chargebacksPrevMonth: 0,
cogs: 0, cogs: 0,
}); });
}
}); });
// Debug check
const finalTotal = products.reduce((sum, p) => sum + p.ppcSpend, 0);
if (Math.abs(finalTotal - totalAdsPassed) > 0.01) {
console.warn(`[MktDataView] PPC Spend Mismatch: Total Ads=${totalAdsPassed.toFixed(2)}, Table Sum=${finalTotal.toFixed(2)}`);
}
return products; return products;
}, [rawData, adsData, dealsMap, promosMap, chargebacksMap]); }, [rawData, adsData, dealsMap, promosMap, chargebacksMap]);